I’ve been lurking on these PRs the last few days:
Those benchmark stats look incredible:
BenchmarkTestCache-8 1673727 751.5 ns/op (Main without risteretto cache)
BenchmarkTestCache-8 2333268 501.3 ns/op (Main with risteretto branch)
BenchmarkTestCache-8 3668409 319.3 ns/op (The PR's improvements)
Running 24.0.4, with the query cache set at 10% (of 256gb ram), we see about 30% improvement. This was with live data ingest stopped. When it’s on, the improvement is less significant. We’re looking forward to the fruits of these PRs to get even fasters!