KeyToHash possibly letting key interfaces escape to heap

diggy · December 2, 2019, 5:49pm

Moved from GitHub ristretto/107

As brought up in the performance Gopher channel, since we’re using interface{} for keys, this call to keyToHash is probably letting the interface escape to heap.

Solution: switch over to string or []byte for public API calls.

diggy · February 21, 2020, 8:02pm

martinmr commented :

@karlmcguire should the change be for keys or keys and values?

LGalatin · September 30, 2020, 11:15pm

some of the issues are fixed by this PR: Improve memory performance by martinmr · Pull Request #195 · dgraph-io/ristretto · GitHub

Topic		Replies	Views
Document behavior on key (hash) collisions Ristretto	1	1148	December 26, 2021
When using `string` as keys, there could be hash collisions, and thus `Get` could return the wrong data Issues ristretto , status:accepted , kind:bug , priority:p1	13	1061	February 21, 2020
Using custom KeyToHash in configuration resulting in drop of cache hit ratio Ristretto ristretto	12	947	July 16, 2020
Why is ristretto using so much memory? Ristretto investigate , ristretto , priority:p2 , status:needs-attenti	17	2844	October 12, 2020
Ristretto should investigate using the new go builtin hash functions Ristretto untagged , ristretto	1	824	June 10, 2020

KeyToHash possibly letting key interfaces escape to heap

Related topics